Repository navigation
Implement NuGet V2 Feed support - #64
Conversation
|
This PR should resolve issue: #59 |
- Changed WebRequestFactory to use static HttpClient to avoid connection socket exhaustion
There was a problem hiding this comment.
Beyond the change to the for loop (and maybe converting the other tests to xUnit to not mix frameworks) looks great. Thanks for contributing this. @madskristensen, can you merge and release when ready? Thanks
passuied
left a comment
There was a problem hiding this comment.
@madskristensen @jaredpar please review and approve PR whenever possible. Installed the change locally and working seamlessly on our nuget v2 feeds hosted in NuGet.Server
|
I can release when @jaredpar or someone with admin rights merges it |
|
@madskristensen @jaredpar Following up on this? How can we find out who is an admin on this repo? |
|
@madskristensen. I understand you don't have admin privileges but not sure who does and how to find out. Does it mean this PR will never get merged? Please advise |
|
I am not an admin for this repo either. I assume someone in @mlorbetske 's org is? |
|
Started an email to figure this out. Will add you all. |
|
@loic-sharma are you an admin on the repo? |
|
I only commented because I'm familiar with the NuGet protocol. I'm not an admin and I don't know who is, sorry 😞 |
|
Oh well... The search continues then... :(
|
|
@jaredpar any update on repo admin search? |
|
@jaredpar @madskristensen it's been another 3 months. Any way to fork the repo and move the build to new repo? |
|
Turns out I have the rights to merge PRs. Apologies for the delay and thanks for the contribution! |
|
Thanks! Glad we found someone with rights!
…On Thu, Jan 9, 2020, 09:47 Kirill Osenkov ***@***.***> wrote:
Turns out I have the rights to merge PRs. Apologies for the delay and
thanks for the contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#64?email_source=notifications&email_token=AAHV5BSAQYLN4G7GDIG3EETQ45PLJA5CNFSM4H6U7QWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIRFF7Q#issuecomment-572674814>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHV5BXN67CBCM5SI44VS6LQ45PLJANCNFSM4H6U7QWA>
.
|
|
@KirillOsenkov @jaredpar @madskristensen who could trigger a build to release new version? |
|
@madskristensen is busy this week but next week hopefully we will find time to create a new CI that can sign the VSIX and publish. The old CI for this repo was before Azure DevOps so we'll need to create a pipeline for Azure DevOps to revive this. Thanks for your patience. |
|
@madskristensen @KirillOsenkov any update on updating CI to Azure DevOps? |
Implement NuGet V2 Feed support.